feat(core, apps): 'PacketDataUnmarshaler' interface added and implemented #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdtrk
requested review from
AdityaSripal,
charleenfei,
colin-axner and
damiannolan
as code owners
srdtrk
requested review from
crodriguezvega,
chatton and
DimitrisJim
as code owners
colin-axner
reviewed
Jul 27, 2023
colin-axner
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Nice one! Only request would be to use the mock application error once #4189 is merged
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4188 +/- ##
==========================================
+ Coverage 79.47% 79.50% +0.02%
==========================================
Files 188 188
Lines 12973 12991 +18
==========================================
+ Hits 10310 10328 +18
Misses 2234 2234
Partials 429 429
|
srdtrk
changed the title
crodriguezvega
approved these changes
Jul 28, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
…nted (#4188) * feat(core/port): added PacketDataUnmarshaler interface * feat(transfer): implemented PacketDataUnmarshaler interface in transfer * feat(ica/controller): implemented PacketDataUnmarshaler interface * feat(fee): implemented PacketDataUnmarshaler interface * feat(mock): implemented PacketDataUnmarshaler interface * imp(transfer_test): removed explicit use of callbacks in tests * style(transfer_test): ran golangci-lint * imp(testing/mock): removed ErrorMock for the upstreamed error * style(fee_test): improved test readability * imp(transfer_test): improved test styling and added new test case (cherry picked from commit 2ac5506) # Conflicts: # modules/apps/27-interchain-accounts/controller/ibc_middleware.go # modules/apps/29-fee/ibc_middleware.go # modules/apps/29-fee/ibc_middleware_test.go # modules/apps/29-fee/types/errors.go # modules/apps/transfer/ibc_module_test.go # testing/mock/ibc_module.go
srdtrk
added a commit
that referenced
this pull request
Aug 1, 2023
…nted (backport #4188) (#4211) * feat(core, apps): 'PacketDataUnmarshaler' interface added and implemented (#4188) * feat(core/port): added PacketDataUnmarshaler interface * feat(transfer): implemented PacketDataUnmarshaler interface in transfer * feat(ica/controller): implemented PacketDataUnmarshaler interface * feat(fee): implemented PacketDataUnmarshaler interface * feat(mock): implemented PacketDataUnmarshaler interface * imp(transfer_test): removed explicit use of callbacks in tests * style(transfer_test): ran golangci-lint * imp(testing/mock): removed ErrorMock for the upstreamed error * style(fee_test): improved test readability * imp(transfer_test): improved test styling and added new test case (cherry picked from commit 2ac5506) # Conflicts: # modules/apps/27-interchain-accounts/controller/ibc_middleware.go # modules/apps/29-fee/ibc_middleware.go # modules/apps/29-fee/ibc_middleware_test.go # modules/apps/29-fee/types/errors.go # modules/apps/transfer/ibc_module_test.go # testing/mock/ibc_module.go * fix: fixed backport conflicts --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: srdtrk <srdtrk@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces the diff when reviewing the adr8 PR #3939.
PacketDataUnmarshaleris an optional interface which allows a middleware to request the packet data to be unmarshaled by the base application.closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.